8000 [FrameworkBundle] Deprecate *not* setting the "framework.router.utf8" option by nicolas-grekas · Pull Request #35310 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Deprecate *not* setting the "framework.router.utf8" option #35310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2020
Merged

[FrameworkBundle] Deprecate *not* setting the "framework.router.utf8" option #35310

merged 1 commit into from
Jan 12, 2020

Conversation

@nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Jan 11, 2020
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? yes
Tickets -
License MIT
Doc PR -

The goal here is to get rid of the config/packages/routing.yaml file in Symfony 6.
This should have no practical impact as all new apps already define this setting for 2 years.

@nicolas-grekas nicolas-grekas added this to the next milestone Jan 11, 2020
@fabpot
Copy link
Member
fabpot commented Jan 12, 2020

Thank you @nicolas-grekas.

@fabpot fabpot mentioned this pull request Jan 12, 2020
Closed
fabpot added a commit that referenced this pull request Jan 12, 2020
@fabpot
feature #35310 [FrameworkBundle] Deprecate *not* setting the "framewo…
fa358e6 
…rk.router.utf8" option (nicolas-grekas)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[FrameworkBundle] Deprecate *not* setting the "framework.router.utf8" option

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | -
| License       | MIT
| Doc PR        | -

The goal here is to get rid of the `config/packages/routing.yaml` file in Symfony 6.
This should have no practical impact as all new apps already define this setting for 2 years.

Commits
-------

84849bc [FrameworkBundle] Deprecate *not* setting the "framework.router.utf8" option
@fabpot fabpot merged commit 84849bc into symfony:master Jan 12, 2020
@nicolas-grekas nicolas-grekas deleted the utf8-deprec branch January 12, 2020 08:08
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

Assignees

No one assigned

Labels

Deprecation FrameworkBundle Status: Reviewed

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas @fabpot @carsonbot
0