8000 Make sure the UriSigner can be autowired by Toflar · Pull Request #35298 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Make sure the UriSigner can be autowired #35298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

Make sure the UriSigner can be autowired #35298

merged 1 commit into from
Jan 10, 2020

Conversation

Toflar
Copy link
Contributor
@Toflar Toflar commented Jan 10, 2020 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

I wasn't able to find the correct spot where this is tested. Is it even tested and if so, can you point me as to where to add tests for that? Thanks 😄

@leofeyer leofeyer mentioned this pull request Jan 10, 2020
Merged
@nicolas-grekas nicolas-grekas added this to the next milestone Jan 10, 2020
@nicolas-grekas
Copy link
Member

We don't have tests for these :)
PR should target master, that's a new feature.

@Toflar
Copy link
Contributor Author
Toflar commented Jan 10, 2020

Damn, I was sure it's going to be 3.4 😆 Okay, let me fix that real quick.

@Toflar Toflar force-pushed the fix-urisigner-not-autowirable branch from 82914ff to 9ad1caa Compare January 10, 2020 11:00
@Toflar Toflar changed the base branch from 3.4 to master January 10, 2020 11:00
@leofeyer
Copy link
Contributor

Is this really a new feature? We will not be able to autowire the URI signer in Symfony 4.4 then, will we?

@Toflar
Copy link
Contributor Author
Toflar commented Jan 10, 2020

Rebased, target branch fixed, description updated.

@fabpot
Copy link
Member
fabpot commented Jan 10, 2020

Thank you @Toflar.

@fabpot fabpot mentioned this pull request Jan 10, 2020
Closed
fabpot added a commit that referenced this pull request Jan 10, 2020
@fabpot
feature #35298 Make sure the UriSigner can be autowired (Toflar)
697bc22 
This PR was merged into the 5.1-dev branch.

Discussion
----------

Make sure the UriSigner can be autowired

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

I wasn't able to find the correct spot where this is tested. Is it even tested and if so, can you point me as to where to add tests for that? Thanks 😄

Commits
-------

9ad1caa Make sure the UriSigner can be autowired
@fabpot fabpot merged commit 9ad1caa into symfony:master Jan 10, 2020
@Toflar Toflar deleted the fix-urisigner-not-autowirable branch January 10, 2020 11:23
@xabbuh
Copy link
Member
xabbuh commented Jan 10, 2020

@leofeyer You can still add the alias yourself if you would like to autowire the UriSigner, but do not want to wait for Symfony 5.1.

@nicolas-grekas nicolas-grekas removed this from the next milestone May 4, 2020
@nicolas-grekas nicolas-grekas added this to the 5.1 milestone May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@aschempp aschempp aschempp approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
7 participants
@Toflar @nicolas-grekas @leofeyer @fabpot @xabbuh @aschempp @carsonbot
0