[SecurityBundle] Avoid direct request dependency in LogoutUrlHelper#3511
Merged
fabpot merged 1 commit intosymfony:masterfrom Mar 6, 2012
jmikola:logout-url-helper-request-dep
Merged
[SecurityBundle] Avoid direct request dependency in LogoutUrlHelper#3511fabpot merged 1 commit intosymfony:masterfrom jmikola:logout-url-helper-request-dep
fabpot merged 1 commit intosymfony:masterfrom
jmikola:logout-url-helper-request-dep
Conversation
This quickly addresses the problem when the helper is constructed in a console environment without request scope. Ideally, the helper should be able to construct the absolute logout URL using data already available in the UrlGenerator's RequestContext and the $_SERVER environment variable; however, that will require copying some code from the Request class to create a base URI and path. Fixes #3508
fabpot
added a commit
that referenced
this pull request
Mar 6, 2012
Commits ------- 8796276 [SecurityBundle] Avoid direct request dependency in LogoutUrlHelper Discussion ---------- [SecurityBundle] Avoid direct request dependency in LogoutUrlHelper This quickly addresses the problem when the helper is constructed in a console environment without request scope. Ideally, the helper should be able to construct the absolute logout URL using data already available in the UrlGenerator's RequestContext and the $_SERVER environment variable; however, that will require copying some code from the Request class to create a base URI and path. Fixes #3508 [](http://travis-ci.org/jmikola/symfony)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This quickly addresses the problem when the helper is constructed in a console environment without request scope. Ideally, the helper should be able to construct the absolute logout URL using data already available in the UrlGenerator's RequestContext and the $_SERVER environment variable; however, that will require copying some code from the Request class to create a base URI and path.
Fixes #3508