CS for AccessDecisionManager #34991
Merged
CS for AccessDecisionManager #34991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 15, 2019
chalasr
approved these changes
Dec 15, 2019
|
Thank you @aschempp. |
chalasr
added a commit
that referenced
this pull request
Dec 15, 2019
This PR was merged into the 3.4 branch. Discussion ---------- CS for AccessDecisionManager | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #34548 | License | MIT | Doc PR | - As discussed in #34548 with @nicolas-grekas here's a CS change for the `AccessDecisionManager` Commits ------- b3742ec CS
|
Hi all, This PR breaks old code because of the type check added here : Some voters in our application were previously returning No big deal, but was it intended ? @nicolas-grekas @chalasr |
|
Breaking your code was not intended, but returning true was not supported either... |
|
@nicolas-grekas It's code from 2015, nice excuse to clean it up 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #34548 with @nicolas-grekas here's a CS change for the
AccessDecisionManager