8000 [Messenger] remove several messages with command messenger:failed:remove by nikophil · Pull Request #34980 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] remove several messages with command messenger:failed:remove #34980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

[Messenger] remove several messages with command messenger:failed:remove #34980

merged 1 commit into from
Jan 10, 2020

Conversation

nikophil
Copy link
Contributor
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #34940
License MIT

command messenger:failed:remove now accepts an array of ids. If several provided, they are not displayed unless option --show-messages is passed

@nikophil nikophil requested a review from sroze as a code owner December 14, 2019 10:28
@nicolas-grekas nicolas-grekas added this to the next milestone Dec 15, 2019
@nikophil
Copy link
Contributor Author
nikophil commented Jan 4, 2020 •
edited
Loading

i don't understand why some tests are failing, in another component, in app veyor 🤔

@fabpot
Copy link
Member
fabpot commented Jan 10, 2020

Thank you @nikophil.

@fabpot fabpot mentioned this pull request Jan 10, 2020
Closed
@fabpot fabpot closed this in 74feb17 Jan 10, 2020
@fabpot fabpot merged commit 903455e into symfony:master Jan 10, 2020
@tienvx tienvx mentioned this pull request May 2, 2020
Merged
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
8312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschaedl jschaedl jschaedl left review comments

@fancyweb fancyweb fancyweb left review comments

@fabpot fabpot fabpot approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

Allow to pass in multiple ids to remove message command
6 participants
@nikophil @fabpot @jschaedl @fancyweb @nicolas-grekas @carsonbot
0