[HttpFoundation] Native Redis Session Storage #3498
Conversation
| * | ||
| * Sets any values redis ini values. | ||
| */ | ||
| protected function setOptions(array $options) |
There was a problem hiding this comment.
As the method only call its parent, I suppose we can remove it, no?
There was a problem hiding this comment.
Yes, I haven't noticed that it is unnecessary.
Thanks, @fabpot.
|
Does Symfony (or any of its dependencies) has Redis support in any form whatsoever? If not this might be a good point to decide which clients to support |
|
well ideally we just get this cache interface stuff done .. for this use case it would be perfect. |
|
There is RedisProfilerStorage available (based on phpredis). I prefer and write code for phpredis. It's recommended by official Redis homepage. In this benchmark is fastest and less memory consumpting. But if somebody prefer predis (with phpiredis), rediska or something other widely used, there are no limitations to add support of it to Symfony. My opinion is, that the C extension should be supported at first, because of good performance and native session storage support. Redis is quite young and the process of creating PHP clients is comparable to Memcache. |
|
+1 on this PR. Needs a test written though. |
|
@pulzarraider I don’t necessarily disagree with the usage of phpredis, I just wanted to bring up the issues of various clients and people having different preferences about them. |
|
@pulzarraider Can you add some unit tests before I merge? |
|
@Drak No there are no php.ini settings. Only RedisArray has some, but it's another feature. @fabpot I've added simple test based on other session storage tests. I planned to create a RedisSessionStorage, too, but I have no time for it now. This can be added later in another PR as it's independent from NativeRedisSessionStorage. |
|
The code looks OK to me. |
|
#3493 has been merged now. |
- fix and simple unit test added
|
Code updated. |
Commits ------- c4ee947 Native Redis Session Storage update 665f593 NativeRedisSessionStorage added Discussion ---------- [HttpFoundation] Native Redis Session Storage Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - --------------------------------------------------------------------------- by lstrojny at 2012-03-04T23:15:43Z Does Symfony (or any of its dependencies) has Redis support in any form whatsoever? If not this might be a good point to decide which clients to support --------------------------------------------------------------------------- by lsmith77 at 2012-03-04T23:36:11Z well ideally we just get this cache interface stuff done .. for this use case it would be perfect. --------------------------------------------------------------------------- by pulzarraider at 2012-03-05T00:35:59Z There is RedisProfilerStorage available (based on phpredis). I prefer and write code for [phpredis](https://github.com/nicolasff/phpredis). It's recommended by [official Redis homepage](http://redis.io/clients#PHP). [In this benchmark](http://dev.af83.com/2011/01/01/which-php-library-to-use-with-redis-the-benchmark.html ) is fastest and less memory consumpting. But if somebody prefer predis (with phpiredis), rediska or something other widely used, there are no limitations to add support of it to Symfony. My opinion is, that the C extension should be supported at first, because of good performance and native session storage support. Redis is quite young and the process of creating PHP clients is comparable to Memcache. There were created pure PHP Memcache clients in the past (Google found for example [this](http://www.phpclasses.org/browse/file/20284.html) and [this](http://code.blitzaffe.com/pages/phpclasses/files/memcached_client_52-12)), but they are not being used now. Everyone, who is seriously thinking about performance, is using only the C Redis/Memcache(d)/... extensions. --------------------------------------------------------------------------- by drak at 2012-03-05T07:40:06Z +1 on this PR. Needs a test written though. I don't think there is any need to wait for #3493 imo. I'll deal with it if this is merged before #3493. Are there any PHP ini settings for this for this driver or is everything via the `session.save_path` directive? (A quick look at the C code seems to indicate there are no explicit ini directives). --------------------------------------------------------------------------- by lstrojny at 2012-03-05T12:14:34Z @pulzarraider I don’t necessarily disagree with the usage of phpredis, I just wanted to bring up the issues of various clients and people having different preferences about them. --------------------------------------------------------------------------- by fabpot at 2012-03-05T14:46:22Z @pulzarraider Can you add some unit tests before I merge? --------------------------------------------------------------------------- by pulzarraider at 2012-03-11T20:19:57Z @Drak No there are no php.ini settings. Only RedisArray has some, but it's another feature. @fabpot I've added simple test based on other session storage tests. I planned to create a RedisSessionStorage, too, but I have no time for it now. This can be added later in another PR as it's independent from NativeRedisSessionStorage. --------------------------------------------------------------------------- by drak at 2012-03-12T02:21:25Z The code looks OK to me. --------------------------------------------------------------------------- by fabpot at 2012-03-15T06:05:27Z #3493 has been merged now. --------------------------------------------------------------------------- by pulzarraider at 2012-03-16T23:21:27Z Code updated.
|
is it just me or is the handler not merged and available ? |
|
These were removed. You can find them here |
|
thanks @Drak |
This PR was merged into the 4.1-dev branch. Discussion ---------- [HttpFoundation] RedisSessionHandler | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24433, #18233, #14539, #4538, #3498 | License | MIT | Doc PR | symfony/symfony-docs#8572 Ability to use Redis as a session storage backend. Discussed in detail in linked issues / PRs. Commits ------- 8776cce [HttpFoundation] Add RedisSessionHandler
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -