8000 [Security] Make remember-me user providers lazy by chalasr · Pull Request #34739 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Make remember-me user providers lazy #34739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2019
Merged

[Security] Make remember-me user providers lazy #34739

merged 1 commit into from
Dec 6, 2019

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Dec 1, 2019 •
edited
Loading
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

As everywhere else

@chalasr chalasr added this to the next milestone Dec 1, 2019
@chalasr chalasr changed the title [Security} Make remember-me user providers lazy [Security] Make remember-me user providers lazy Dec 1, 2019
@chalasr chalasr changed the base branch from master to 4.4 December 1, 2019 13:10
@chalasr chalasr force-pushed the remem-lazy-providers branch from a0f1548 to b27b49f Compare December 1, 2019 13:10
@chalasr chalasr modified the milestones: next, 4.4 Dec 1, 2019
@chalasr
Copy link
Member Author
chalasr commented Dec 1, 2019

Now targetting 4.4 to not break 4-to-5 compat between security-bundle and security-http.

@chalasr chalasr force-pushed the remem-lazy-providers branch from b27b49f to 4ba5201 Compare December 3, 2019 20:39
@chalasr chalasr force-pushed the remem-lazy-providers branch 3 times, most recently from 96cb010 to 1fd1bb0 Compare December 3, 2019 21:41
@fabpot
Copy link
Member
fabpot commented Dec 4, 2019

It's not a bug fix, that's for 5.1 IMHO.

@chalasr chalasr modified the milestones: 4.4, next Dec 4, 2019
@chalasr chalasr changed the base branch from 4.4 to master December 4, 2019 07:30
@chalasr chalasr force-pushed the remem-lazy-providers branch from 1fd1bb0 to 78bedef Compare December 4, 2019 07:31
@chalasr chalasr force-pushed the remem-lazy-providers branch from 78bedef to bea7456 Compare December 4, 2019 07:39
@chalasr
Copy link
Member Author
chalasr commented Dec 4, 2019

Rebased on master.

chalasr added a commit that referenced this pull request Dec 6, 2019
@chalasr
minor #34739 [Security] Make remember-me user providers lazy (chalasr)
0d2f411 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[Security] Make remember-me user providers lazy

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

As everywhere else

Commits
-------

bea7456 [Security} Make remember-me user providers lazy
@chalasr chalasr merged commit bea7456 into symfony:master Dec 6, 2019
@chalasr chalasr deleted the remem-lazy-providers branch December 6, 2019 23:09
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Security SecurityBundle Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@chalasr @fabpot @nicolas-grekas @stof @carsonbot
0