[HttpKernel][DataCollectorInterface] Ease compatibility #34650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
Works for me: having upgraded several bundles, it's the single change that requires bumping the minimum Symfony version and that's quite artificial.
This makes ppl create compatibility traits, e.g. https://github.com/snc/SncRedisBundle/blob/master/DataCollector/DataCollectorSymfonyCompatibilityTrait.php
ogizanagi
approved these changes
Nov 27, 2019
fancyweb
approved these changes
Nov 27, 2019
|
Closing as discussed on the linked PR (#34230 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #34230. This allows data collectors in Symfony 3.4 have the same syntax as in 4.3+. Otherwise it's difficult to create code that's compatible with Symfony 3.4 and 5.0 at the same time.