[Intl] [Workflow] fixes English grammar typos #34603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
approved these changes
Nov 25, 2019
|
Please open a PR against the 3.4 branch (oldest supported branch) fixing all occurrences there. Then, we'll need additional PRs for newer branches (4.3 and then 4.4) only for phpdoc which does not exist in older versions (which might mean we don't need the PR at all). |
|
@stof yes I'll open a PR against 3.4 to fix the other occurrences. This class was introduced in Symfony 4.3 so this is the reason why I isolated the patch in this PR. |
|
And that's why I 👍 the PR |
14ff77a to
492e1b5
Compare
darielopper
approved these changes
Nov 25, 2019
fabpot
approved these changes
Nov 26, 2019
|
Good catch, thanks @hhamon. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Intl] [Workflow] fixes English grammar typos | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ Also related to #34604 Commits ------- 492e1b5 [Intl] [Workflow] fixes English grammar typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also related to #34604