[Security] Changed has_role to is_granted for expression in upgrade 4.4 #34593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 25, 2019
yceruto
approved these changes
Nov 25, 2019
xabbuh
approved these changes
Nov 25, 2019
fabpot
approved these changes
Nov 26, 2019
|
Thank you @linaori. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2019
… in upgrade 4.4 (linaori) This PR was merged into the 4.4 branch. Discussion ---------- [Security] Changed has_role to is_granted for expression in upgrade 4.4 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | ~ <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | ~ <!-- required for new features --> A user on slack was looking for a replacement for the `[ROLE1, ROLE2]` notation on `$this->denyAccessUnlessGranted`. After searching for `has_role`, they pointed out that the function has been deprecated as well: https://github.com/symfony/security/blob/297ac031eeae519c87b400ff6ed7fc1819e64d73/Core/Authorization/ExpressionLanguageProvider.php#L57-L65 This PR fixes the upgrade guide to point to the non-deprecated alternative. Additionally it turns out that the removal of `has_role()` has not been documented in `UPGRADE-5.0.md` _remake of #34592, there will be another PR for security/CHANGELOG.md in 5.0_ Commits ------- 78ff806 has_roles should be is_granted in upgrade files
fabpot
added a commit
that referenced
this pull request
Nov 26, 2019
… in upgrade 5.0 (linaori) This PR was merged into the 5.0 branch. Discussion ---------- [Security] Changed has_role to is_granted for expression in upgrade 5.0 | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | ~ <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | ~ <!-- required for new features --> Changes for #34593 that can only be applied on 5.0+ Commits ------- 2f1336e has_roles should be is_granted in security upgrade file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user on slack was looking for a replacement for the
[ROLE1, ROLE2]notation on$this->denyAccessUnlessGranted. After searching forhas_role, they pointed out that the function has been deprecated as well: https://github.com/symfony/security/blob/297ac031eeae519c87b400ff6ed7fc1819e64d73/Core/Authorization/ExpressionLanguageProvider.php#L57-L65This PR fixes the upgrade guide to point to the non-deprecated alternative.
Additionally it turns out that the removal of
has_role()has not been documented inUPGRADE-5.0.mdremake of #34592, there will be another PR for security/CHANGELOG.md in 5.0