8000 [Workflow] Added `Registry::has()` to check if a workflow exists by lyrixx · Pull Request #34591 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Workflow] Added Registry::has() to check if a workflow exists #34591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2019
Merged

[Workflow] Added Registry::has() to check if a workflow exists #34591

merged 1 commit into from
Nov 29, 2019

Conversation

lyrixx
Copy link
Member
@lyrixx lyrixx commented Nov 25, 2019 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #34584
License MIT
Doc PR

Allow to use

$registry->has($subject);
// or 
$registry->has($subject, 'workflow_a')

@nicolas-grekas nicolas-grekas added this to the next milestone Nov 25, 2019
@lyrixx lyrixx force-pushed the workflow-registry-has branch from 11866e1 to 8a4f03d Compare November 25, 2019 15:20
@javiereguiluz
Copy link
Member

@lyrixx thanks for this contribution. In order to make this ready to be documented, could you please add some little example to the pull request description. Also, please tell us if there are some things to keep in mind about this feature (e.g. edge cases where it doesn't work, etc.) Thanks!

@lyrixx
Copy link
Member Author
lyrixx commented Nov 27, 2019

@javiereguiluz I'm not sure it worth documenting it. This method is discoverable easily with autocomplete and It make what it is supposed to without edge case. Anyway I added a s mall example

lyrixx added a commit that referenced this pull request Nov 29, 2019
@lyrixx
feature #34591 [Workflow] Added Registry::has() to check if a workf…
0a91f9b 
…low exists (lyrixx)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Workflow] Added `Registry::has()` to check if a workflow exists

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #34584
| License       | MIT
| Doc PR        |

---

Allow to use
```php
$registry->has($subject);
// or
$registry->has($subject, 'workflow_a')
```

Commits
-------

8a4f03d [Workflow] Added `Registry::has()` to check if a workflow exists
@lyrixx lyrixx merged commit 8a4f03d into symfony:master Nov 29, 2019
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@lyrixx lyrixx deleted the workflow-registry-has branch June 30, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Feature Status: Needs Review Workflow
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

Workflow component should allow to check if object has a workflow defined
4 participants
@lyrixx @javiereguiluz @nicolas-grekas @carsonbot
0