[DI] Add "force_parameters_escape" option to dumpers #34541
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aec766c to
72e361f
Compare
|
I don't think this is the right approach. This will break scripts that expect the current escaping strategy that varies by compiled/not-compiled. |
|
Closing as explained, let's continue on 4.4 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ContainerBuilderDebugDumpPasswe dump an uncompiled container. That means the dumpers do not escape parameters. I guess we need to add an easy way to force this escaping. That fixes the problem with the new lint command. It was not detected before because thedebug:containercommand never compiles the container (contrary to the new one).If it's too complicated, we could just rebuild a fresh container everytime in the lint command.
#SymfonyHackday