Simpler example for Apache basic auth workaround #34460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 28, 2019
|
Can you please check if the doc needs a similar patch? |
Uses a simpler regex and existing back-reference instead of reading header twice.
|
Thank you @Roy-Orbison. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 28, 2019
…bison) This PR was submitted for the master branch but it was merged into the 3.4 branch instead. Discussion ---------- Simpler example for Apache basic auth workaround Uses a simpler regex and existing back-reference instead of reading header twice. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #1813 | License | MIT Improvement to code documentation, no change to executed code. Commits ------- 388528d Simpler example for Apache basic auth workaround
|
Which doc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a simpler regex and existing back-reference instead of reading header twice.
Improvement to code documentation, no change to executed code.