8000 [HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit by chalasr · Pull Request #34430 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit #34430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2019
Merged

[HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit #34430

merged 1 commit into from
Nov 18, 2019

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Nov 17, 2019 •
edited
Loading
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

One less BC break for 5.0

@chalasr chalasr added this to the 4.4 milestone Nov 17, 2019
@chalasr chalasr force-pushed the errlistener-dispatch branch from 7d3534f to aab9b43 Compare November 17, 2019 23:49
@nicolas-grekas
Copy link
Member

Thank you @chalasr.

nicolas-grekas added a commit that referenced this pull request Nov 18, 2019
@nicolas-grekas
minor #34430 [HttpKernel] Make ErrorListener::onKernelException()'s d…
4498e7e 
…ispatcher argument explicit (chalasr)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

One less BC break for 5.0

Commits
-------

aab9b43 [HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit
@nicolas-grekas nicolas-grekas merged commit aab9b43 into symfony:4.4 Nov 18, 2019
@chalasr chalasr deleted the errlistener-dispatch branch November 18, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HttpKernel Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @nicolas-grekas @carsonbot
0