8000 [FrameworkBundle] Remove project dir from Translator cache vary scanned directories by fancyweb · Pull Request #34397 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Remove project dir from Translator cache vary scanned directories #34397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2019
Merged

[FrameworkBundle] Remove project dir from Translator cache vary scanned directories #34397

merged 1 commit into from
Nov 17, 2019

Conversation

fancyweb
Copy link
Contributor
@fancyweb fancyweb commented Nov 15, 2019 •
edited by nicolas-grekas
Loading
Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Closes #34395
License MIT
Doc PR -

Weird cases such as having different paths for directories found through reflection (cf

symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Line 1105 in 8522a88

$dirs[] = $transPaths[] = \dirname($r->getFileName()).'/Resources/translations';
) or using different values on warmup and run for another parameter than kernel.project_dir are still unconvered. Unfortunately there is nothing we can do, do we care? If yes, then we might just wanna enable #34129 when the debug option is on.

@fancyweb fancyweb force-pushed the fwb-fix-translator-cache branch 2 times, most recently from 1b22541 to 05edec7 Compare November 15, 2019 15:41
stof
stof reviewed Nov 15, 2019
View reviewed changes
@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Nov 15, 2019
@fancyweb fancyweb force-pushed the fwb-fix-translator-cache branch 5 times, most recently from 9f40567 to bacc63b Compare November 16, 2019 19:16
@fancyweb fancyweb force-pushed the fwb-fix-translator-cache branch from bacc63b to e75e01d Compare November 17, 2019 09:27
@fabpot
Copy link
Member
fabpot commented Nov 17, 2019

Thank you @fancyweb.

fabpot added a commit that referenced this pull request Nov 17, 2019
@fabpot
bug #34397 [FrameworkBundle] Remove project dir from Translator cache…
3b237ce 
… vary scanned directories (fancyweb)

This PR was merged into the 4.3 branch.

Discussion
----------

[FrameworkBundle] Remove project dir from Translator cache vary scanned directories

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Closes #34395
| License       | MIT
| Doc PR        | -

Weird cases such as having different paths for directories found through reflection (cf https://github.com/symfony/symfony/blob/8522a88185a7e283ad342b3539cd088d76968df9/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L1105) or using different values on warmup and run for another parameter than `kernel.project_dir` are still unconvered. Unfortunately there is nothing we can do, do we care? If yes, then we might just wanna enable #34129 when the `debug` option is on.

Commits
-------

e75e01d [FrameworkBundle] Remove project dir from Translator cache vary scanned directories
@fabpot fabpot merged commit e75e01d into symfony:4.3 Nov 17, 2019
This was referenced Nov 17, 2019
Merged
Merged
@fabpot fabpot mentioned this pull request Dec 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Ready Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@fancyweb @fabpot @nicolas-grekas @stof @carsonbot
0