Fix tests #3438
Merged
Fix tests #3438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for putting the memcache tests in a group. |
fabpot
added a commit
that referenced
this pull request
Feb 24, 2012
Commits ------- e67f8d4 Properly skip memcached tests when no memcached server is present 005d86f Broaden timer tests limits 001c4fd Fix windows fs tests Discussion ---------- Fix tests - Some windows fixes - Skip memcached for real when it's not there - by the way I think those tests are insane since they seem to run a purge() on the memcached server. If you run this by accident somewhere where it matters it could hurt. I think they should be put in a group disabled by default, I'll be happy to add that change if it's deemed useful. - Fixed the timer tests for good on windows (which seems to be quite bad at `usleep`). I also documented them so you actually know how it failed when it does, the false instead of true wasn't super useful.
| $event->stop(); | ||
| $total = $event->getTotalTime(); | ||
| $this->assertTrue($total >= 9 && $total <= 20); | ||
| $this->assertTrue($total > 10 && $total <= 29, $total.' should be 20 (between 10 and 29)'); |
There was a problem hiding this comment.
Naming is inconsistent. Here is means higher than 10 (exclusive 10) and in line 104 is means inclusive 21.
Btw, these test still fail on my windows. I get higher values, e.g. 31.4.
There was a problem hiding this comment.
Please send a PR if you really think this matters - sorry but I can't see this file anymore :) And yeah I'm sure it still will fail every now and then, but hopefully rarely enough that it is not too distracting when developing. The only solution would be to increase the sleeps so that small inaccuracies become less relevant, but that makes running the tests annoying too.
fabpot
added a commit
that referenced
this pull request
Feb 27, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usleep). I also documented them so you actually know how it failed when it does, the false instead of true wasn't super useful.