8000 [Messenger] Perform no deep merging of bus middleware by vudaltsov · Pull Request #34347 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Messenger] Perform no deep merging of bus middleware #34347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2019

Conversation

vudaltsov
Copy link
Contributor
Q A
Branch? 4.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

This change helps in case one needs to configure a bus differently for a custom environment while keeping existing handlers attached by name.

@nicolas-grekas
Copy link
Member

Looks similar to #32970, on a different node. Looks like a changelog entry would be needed. Please also check the discussion in case it makes sense here too.

@vudaltsov
Copy link
Contributor Author

@nicolas-grekas , added a changelog entry and a test that proves the changes are correct from my POV.

@fabpot fabpot force-pushed the dont-merge-middleware branch from 8cad0ec to c264583 Compare November 17, 2019 10:02
@fabpot
Copy link
Member
fabpot commented Nov 17, 2019

Thank you @vudaltsov.

fabpot added a commit that referenced this pull request Nov 17, 2019
…altsov)

This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] Perform no deep merging of bus middleware

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

This change helps in case one needs to configure a bus differently for a custom environment while keeping existing handlers attached by name.

Commits
-------

c264583 [Messenger] Perform no deep merging of bus middleware
@fabpot fabpot merged commit c264583 into symfony:4.4 Nov 17, 2019
@vudaltsov vudaltsov deleted the dont-merge-middleware branch November 17, 2019 10:11
This was referenced Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0