[DI] fix loading env while env loaders are loaded #34301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
jderusse
reviewed
Nov 8, 2019
| @@ -141,15 +141,20 @@ public function getEnv($prefix, $name, \Closure $getEnv) | |||
| } | |||
| } | |||
|
|
|||
| $loaders = $this->loaders; | |||
| $this->loaders = new \ArrayIterator(); | |||
There was a problem hiding this comment.
what if an envLoader needs an other envLoader?
for instance, what's if the Consul loader proposed by @lyrixx #34295 (comment) needs a secret?
There was a problem hiding this comment.
That will work thanks to the loadedVars array - but first loaders cannot use latter ones.
nicolas-grekas
added a commit
that referenced
this pull request
Nov 8, 2019
…-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DI] fix loading env while env loaders are loaded | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 522bd5d [DI] fix loading env while env loaders are loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.