10000 [VarDumper] Clean casters @final annotations by fancyweb · Pull Request #34266 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarDumper] Clean casters @final annotations #34266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

[VarDumper] Clean casters @final annotations #34266

merged 1 commit into from
Nov 7, 2019

Conversation

fancyweb
Copy link
Contributor
@fancyweb fancyweb commented Nov 6, 2019
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Clean #33882 on master.

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Nov 6, 2019
@nicolas-grekas
Copy link
Member

CI is back to green, can you please rebase?

@fancyweb fancyweb force-pushed the var-dumper-apply-final-on-casters branch from 1ae5f46 to aa76b45 Compare November 6, 2019 17:44
@fancyweb fancyweb force-pushed the var-dumper-apply-final-on-casters branch from aa76b45 to ce35ca2 Compare November 6, 2019 18:00
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

nicolas-grekas added a commit that referenced this pull request Nov 7, 2019
@nicolas-grekas < 8BC9 /a>
minor #34266 [VarDumper] Clean casters @Final annotations (fancyweb)
3d8cca8 
This PR was merged into the 5.0-dev branch.

Discussion
----------

[VarDumper] Clean casters @Final annotations

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Clean #33882 on master.

Commits
-------

ce35ca2 [VarDumper] Clean casters @Final annotations
@nicolas-grekas nicolas-grekas merged commit ce35ca2 into symfony:master Nov 7, 2019
@fancyweb fancyweb deleted the var-dumper-apply-final-on-casters branch November 7, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review VarDumper
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fancyweb @nicolas-grekas @carsonbot
0