8000 [OptionsResolver] Fix an error message to be more accurate by yceruto · Pull Request #34157 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[OptionsResolver] Fix an error message to be more accurate #34157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2019
Merged

[OptionsResolver] Fix an error message to be more accurate #34157

merged 1 commit into from
Oct 28, 2019

Conversation

yceruto
Copy link
Member
@yceruto yceruto commented Oct 28, 2019
Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #30432
License MIT
Doc PR -

Follow-up #30442 for 4.3

@yceruto yceruto added this to the 4.3 milestone Oct 28, 2019
@yceruto yceruto mentioned this pull request Oct 28, 2019
Merged
@yceruto yceruto force-pushed the options_resolver_error_43 branch from 5ed682d to 1be68a7 Compare October 28, 2019 21:03
@yceruto
Copy link
Member Author
yceruto commented Oct 28, 2019

It's ready (failues are not related now)

@nicolas-grekas
Copy link
Member

Thank you @yceruto.

nicolas-grekas added a commit that referenced this pull request Oct 28, 2019
@nicolas-grekas
minor #34157 [OptionsResolver] Fix an error message to be more accura…
7b3d5cd 
…te (yceruto)

This PR was merged into the 4.3 branch.

Discussion
----------

[OptionsResolver] Fix an error message to be more accurate

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #30432
| License       | MIT
| Doc PR        | -

Follow-up #30442 for 4.3

Commits
-------

1be68a7 Fix an error message to be more accurate
@nicolas-grekas nicolas-grekas merged commit 1be68a7 into symfony:4.3 Oct 28, 2019
@yceruto yceruto deleted the options_resolver_error_43 branch October 28, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug OptionsResolver Status: Needs Review
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@yceruto @nicolas-grekas @carsonbot
0