8000 [Notifier] add RocketChat bridge by Jeroeny · Pull Request #34022 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] add RocketChat bridge #34022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

[Notifier] add RocketChat bridge #34022

merged 1 commit into from
Feb 10, 2020

Conversation

Jeroeny
Copy link
Contributor
@Jeroeny Jeroeny commented Oct 18, 2019
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets See #33687
License MIT

This would add RocketChat integration for the Notifier component. RocketChat is a self hosted chat service.

Fully tested with a trial version of RocketChat.

@Wirone I noticed you suggested this.

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone < 8000 a href="#event-2724474653" class="Link--secondary">Oct 18, 2019
@Wirone
Copy link
Contributor
Wirone commented Oct 18, 2019

@Jeroeny yeah, I suggested it and even thought about implementation, but you were first 😉 👍

@nicolas-grekas nicolas-grekas modified the milestones: 5.0, next Nov 6, 2019
@Jeroeny
Copy link
Contributor Author
Jeroeny commented Nov 13, 2019 •
edited
Loading

Is this good to go?

Edit: Actually, looking at #33875, I think it's missing:

  • Symfony/Component/Notifier/Transport.php Factory class
  • Framework extension entry and config change
  • Notifier/Exception/UnsupportedSchemeException.php entry

Edit: Fixed

@Jeroeny
Copy link
Contributor Author
Jeroeny commented Jan 4, 2020

Because I updated from the 5.0 upstream branch, which was wrong, I had 600+ commits as diff, also causing GitHub to request reviews from code owners. My bad, I reverted that push.

OskarStark
OskarStark approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@fabpot
Copy link
Member
fabpot commented Feb 10, 2020

@Jeroeny Can you rebase to get rid of the merge commit? Thank you.

@Jeroeny Jeroeny force-pushed the rocketchat branch 2 times, most recently from 34ea398 to 1fbf793 Compare February 10, 2020 13:33
@Jeroeny Jeroeny requested a review from fabpot February 10, 2020 13:44
@fabpot
Copy link
Member
fabpot commented Feb 10, 2020

Thank you @Jeroeny.

@fabpot fabpot mentioned this pull request Feb 10, 2020
Closed
@fabpot fabpot closed this in 1d472a6 Feb 10, 2020
@fabpot fabpot merged commit 4869ef6 into symfony:master Feb 10, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@tambait tambait mentioned this pull request Aug 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePanz thePanz thePanz left review comments

@antiseptikk antiseptikk antiseptikk left review comments

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
5.1
4164
Development

Successfully merging this pull request may close these issues.
9 participants
@Jeroeny @Wirone @fabpot @thePanz @OskarStark @antiseptikk @nicolas-grekas @yceruto @carsonbot
0