[DoctrineBridge] Auto-validation must work if no regex are passed #33828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least, the behavior must be consistent between |
|
The current behavior makes it harder to use this class when using only the component (without framework bundle). I'm favor of patching FrameworkBundle instead. |
|
Deregistering the loader service when no regex is configured would solve that, right? |
|
Indeed, it’s what I have in mind. |
5612e7d to
b2d05a0
Compare
|
@xabbuh implemented, could you check if it's ok for you now? |
nicolas-grekas
approved these changes
Oct 29, 2019
xabbuh
approved these changes
Oct 29, 2019
b2d05a0 to
5ed7d6c
Compare
dunglas
added a commit
that referenced
this pull request
Oct 29, 2019
… passed (dunglas) This PR was squashed before being merged into the 4.3 branch (closes #33828). Discussion ---------- [DoctrineBridge] Auto-validation must work if no regex are passed | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a | License | MIT | Doc PR | n/a Backport of https://github.com/symfony/symfony/pull/32107/files#r295762928. This behavior if faulty, if no regex are passed, autvalidation must be triggered, [as done in `PropertyInfoLoader`](https://github.com/symfony/symfony/blob/4.3/src/Symfony/Component/Validator/Mapping/Loader/PropertyInfoLoader.php#L50). Commits ------- 5ed7d6c [DoctrineBridge] Auto-validation must work if no regex are passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of https://github.com/symfony/symfony/pull/32107/files#r295762928.
This behavior if faulty, if no regex are passed, autvalidation must be triggered, as done in
PropertyInfoLoader.