[Contracts] Don't remove object type declaration from PSR interface #33786
Conversation
|
this is broken. The |
The code branch that was changed here is not executed on php 7.1. The PSR interface itself (which is extended here) requires php 7.2. |
|
but this means that our own interface now has a different signature depending on whether the PSR interface is installed, which would be very confusing (and we cannot do it in both branches because of the PHP version). |
Correct. An implementation that supports both branches would remove Note: we already remove the upstream |
|
@derrabus no, you're not only doing that. Currently, our own interface always have the same signature. You are making it an interface with a varying signature. |
That is correct. |
|
I would not make this in v1.1, but in v2.0 we would add the type to both interfaces, isn't it? |
Agreed, let's close here. Thanks @stof and @nicolas-grekas.
#33497 currently proposes to merge both interfaces by making the PSR package a mandatory dependency. And yes, I've added the type declaration there. |
In the contracts package, when extending the PSR
EventDispatcherInterface, we are removing theobjectparameter type declaration from thedispatch()method. This is how the interface looks like upstream:https://github.com/php-fig/event-dispatcher/blob/1.0.0/src/EventDispatcherInterface.php#L20
I don't see a reason to do that. Keeping the declaration would allow implementers to keep the
objecttype declaration when implementing our contracts interface together with the PSR one.