8000 Fix version typo in deprecation notice by teohhanhui · Pull Request #33668 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Fix version typo in deprecation notice #33668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Conversation

teohhanhui
Copy link
Contributor
Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

#28865 was merged into 4.3

Copy link
Contributor
@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @deprecated tag in the PhpDoc is not good too ;)

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Sep 23, 2019
@fabpot
Copy link
Member
fabpot commented Sep 23, 2019

Thank you @teohhanhui.

fabpot added a commit that referenced this pull request Sep 23, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

Fix version typo in deprecation notice

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

#28865 was merged into 4.3

Commits
-------

bd13271 Fix version typo in deprecation notice
@fabpot fabpot merged commit bd13271 into symfony:4.3 Sep 23, 2019
@teohhanhui teohhanhui deleted the patch-3 branch September 23, 2019 17:31
@xabbuh
Copy link
Member
xabbuh commented Sep 25, 2019

@maxhelias fixed in e016145, thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0