10000 [Lock] use Predis\ClientInterface instead of Predis\Client by seferov · Pull Request #33666 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Lock] use Predis\ClientInterface instead of Predis\Client #33666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2019
Merged

[Lock] use Predis\ClientInterface instead of Predis\Client #33666

merged 1 commit into from
Sep 23, 2019

Conversation

seferov
Copy link
Contributor
@seferov seferov commented Sep 23, 2019
Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

\Predis\ClientInterface can be used instead of \Predis\Client for RedisStore.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Sep 23, 2019
@nicolas-grekas
Copy link
Member

grep '@param .*Predis.Client' src/ -r yields more results, let's update them all.

@fabpot
Copy link
Member
fabpot commented Sep 23, 2019

Thank you @seferov.

fabpot added a commit that referenced this pull request Sep 23, 2019
@fabpot
minor #33666 [Lock] use Predis\ClientInterface instead of Predis\Clie…
35b6701 
…nt (seferov)

This PR was squashed before being merged into the 3.4 branch (closes #33666).

Discussion
----------

[Lock] use Predis\ClientInterface instead of Predis\Client

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

`\Predis\ClientInterface` can be used instead of `\Predis\Client` for RedisStore.

Commits
-------

5c01f0a [Lock] use Predis\ClientInterface instead of Predis\Client
@fabpot fabpot merged commit 5c01f0a into symfony:3.4 Sep 23, 2019
@seferov seferov deleted the patch-1 branch September 23, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@muminaydin muminaydin muminaydin approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Bug Lock Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@seferov @nicolas-grekas @fabpot @muminaydin @stof @carsonbot
0