[Config] Cleanup, error detection, fixes #3365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vicb As you added new exceptions, IMO you should add some tests to cover it. |
|
good point, I'll do. |
|
@stloyd that was a great idea, I realized I had miss a case. It has been added and should be covered by UT + fixes made. I am done with the fixes, should be ready to merge. And time to give the |
fabpot
added a commit
that referenced
this pull request
Feb 16, 2012
Commits ------- 0a176eb [FrameworkBundle] Fix configuration errors 6745b28 [Config] Throw exceptions on invalid definition fb27de0 [Config] cleanup Discussion ---------- [Config] Cleanup, error detection, fixes see #3357 --------------------------------------------------------------------------- by stloyd at 2012-02-15T10:56:00Z @vicb As you added new exceptions, IMO you should add some tests to cover it. --------------------------------------------------------------------------- by vicb at 2012-02-15T10:56:50Z good point, I'll do. --------------------------------------------------------------------------- by vicb at 2012-02-15T13:49:44Z @stloyd that was a great idea, I realized I had miss a case. It has been added and should be covered by UT + fixes made. I am done with the fixes, should be ready to merge. And time to give the `PrototypedArrayNode` some more usability now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this sugg
3128
estion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3357