8000 install from source to include components tests by xabbuh · Pull Request #33637 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

install from source to include components tests #33637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2019
Merged

install from source to include components tests #33637

merged 2 commits into from
Sep 19, 2019

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Sep 19, 2019 •
edited by nicolas-grekas
Loading
Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Replaces #33634

@xabbuh xabbuh added this to the 3.4 milestone Sep 19, 2019
@xabbuh xabbuh mentioned this pull request Sep 19, 2019
Closed
@xabbuh
Revert "bug symfony#33618 fix tests depending on other components' te…
5aa4328 
…sts (xabbuh)"

This reverts commit 47fb090, reversing
changes made to 6fad4f1.
@xabbuh xabbuh marked this pull request as ready for review September 19, 2019 07:18
nicolas-grekas
nicolas-grekas approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the only sensible solution to make the CI back to green.

BUT 1. this adds ~3-4 minutes per deps=low/high jobs, almost doubling their time while they're already a blocker on (not so) busy days and 2. it makes running the tests locally quite painful: ppl will have to use --prefer-source when testing a single component - this means a. ppl should learn about it and b. they will have to wait more time to get up and running.

I think we should revert the PR that added .gitattributes. Active contributors should not be paying with their free time for ppl that only "+1" without caring about the consequences.

Instead, I think we should discuss a way to remove Tests folders from flex, opt-in.

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

nicolas-grekas added a commit that referenced this pull request Sep 19, 2019
@nicolas-grekas
minor #33637 install from source to include components tests (xabbuh)
6bf2dd9 
This PR was squashed before being merged into the 3.4 branch (closes #33637).

Discussion
----------

install from source to include components tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

5aa4328 Revert "bug #33618 fix tests depending on other components' tests (xabbuh)"
c792908 install from source to include components tests
@nicolas-grekas nicolas-grekas merged commit 5aa4328 into symfony:3.4 Sep 19, 2019
@xabbuh xabbuh deleted the pr-33579-source-installs branch September 19, 2019 08:12
@nicolas-grekas
Copy link
Member

Issue 1. 889F is fixed by #33654

@staabm staabm mentioned this pull request Oct 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot
0