[Twig] Add NotificationEmail #33605
Merged
[Twig] Add NotificationEmail #33605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ed3854 to
59e1121
Compare
lyrixx
reviewed
Sep 17, 2019
6f046d9 to
8ac1213
Compare
rbaarsma
reviewed
Sep 17, 2019
b22e44c to
ba2a6ae
Compare
yceruto
reviewed
Sep 17, 2019
src/Symfony/Bundle/TwigBundle/DependencyInjection/Compiler/ExtensionPass.php
Show resolved
Hide resolved
stof
reviewed
Sep 17, 2019
src/Symfony/Bridge/Twig/Resources/views/Email/notification_body_markdown.html.twig
Outdated
Show resolved
Hide resolved
stof
reviewed
Sep 17, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
stof
requested changes
Sep 17, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
2e50155 to
a87f58c
Compare
OskarStark
reviewed
Sep 17, 2019
49cf6eb to
0930f97
Compare
|
New iteration: I've replaced the default templates by a theme. One can set a default theme ( |
b97af7e to
58d28b0
Compare
OskarStark
reviewed
Sep 17, 2019
d0f4c86 to
c3836ab
Compare
|
I've also changed the naming scheme so that we can add more built-in templates over time ( |
bd8662d to
dfa0f41
Compare
stof
reviewed
Sep 18, 2019
yceruto
reviewed
Sep 18, 2019
src/Symfony/Bridge/Twig/Resources/views/Email/zurb_2/notification/body.html.twig
Show resolved
Hide resolved
dfa0f41 to
464c442
Compare
|
I think this one is ready now. |
yceruto
approved these changes
Sep 18, 2019
|
AppVeyor's failure is related https://ci.appveyor.com/project/fabpot/symfony/builds/27497465#L71 |
fe7ed57 to
d7f5aee
Compare
yceruto
reviewed
Sep 18, 2019
d7f5aee to
f6c6cf7
Compare
|
Tests are now as green as possible :) |
fabpot
added a commit
that referenced
this pull request
Sep 18, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Twig] Add NotificationEmail | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | - This PR is an extract of the new Notifier component. It's a default template to send standardized emails with the Mailer component, which can be used independently of the Notifier component. Such emails look like the following: <img width="618" alt="image" src="https://user-images.githubusercontent.com/47313/65018883-694cb780-d92a-11e9-940a-875ea68f9e5d.png"> More info on SpeakerDeck (be warned that names have change since my presentation): https://speakerdeck.com/fabpot/symfony-notifier?slide=7 It requires Twig 1.12 which should be released later this week. Usage example: ```php $email = (new NotificationEmail()) ->from('fabien@example.com') ->to('fabien@example.org') ->subject('My first notification email via Symfony') ->markdown(<<<EOF There is a **problem** on your website, you should investigate it right now. Or just wait, the problem might solves itself automatically, we never know. EOF ) ->action('More info?', 'https://example.com/') ->importance('high') //->exception(new \LogicException('That does not work at all...')) ; ``` Instead of `markdown()`, you can also use `content()` for simple emails. Note that you can use Inky tags in the content: ```php $email = (new NotificationEmail()) ->from('fabien@example.com') ->to('fabien@example.org') ->subject('My first notification email via Symfony') ->markdown(<<<EOF There is a **problem** on your website, you should investigate it right now. Or just wait, the problem might solves itself automatically, we never know. Some Title ========== <center> <button href="https://example.com/">Go?</button> </center> EOF ); ``` There is also the concept of a theme. By default, it uses the `default` theme, which is an alias for the `zurb_2` theme. You can use `setTheme()` to override the theme for a given instance, or override the themes globally via the following config in `twig.yaml`: ```yaml twig: paths: templates/email: email ``` Then, create `templates/email/default/notification/body.html.twig` and `templates/email/default/notification/body.txt.twig`. Extends the existing template via `{% extends "@!email/default/notification/body.html.twig" %}` (note the `!`). Commits ------- f6c6cf7 [Twig] Add NotificationEmail
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an extract of the new Notifier component. It's a default template to send standardized emails with the Mailer component, which can be used independently of the Notifier component.
Such emails look like the following:
More info on SpeakerDeck (be warned that names have change since my presentation): https://speakerdeck.com/fabpot/symfony-notifier?slide=7
It requires Twig 1.12 which should be released later this week.
Usage example:
Instead of
markdown(), you can also usecontent()for simple emails.Note that you can use Inky tags in the content:
There is also the concept of a theme. By default, it uses the
defaulttheme, which is an alias for thezurb_2theme.You can use
setTheme()to override the theme for a given instance, or override the themes globally via the following config intwig.yaml:Then, create
templates/email/default/notification/body.html.twigandtemplates/email/default/notification/body.txt.twig. Extends the existing template via{% extends "@!email/default/notification/body.html.twig" %}(note the!).