8000 [DI] fix Preloader by nicolas-grekas · Pull Request #33525 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] fix Preloader #33525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2019
Merged

[DI] fix Preloader #33525

merged 1 commit into from
Sep 10, 2019

Conversation

nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Sep 10, 2019 •
edited
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets https://github.com/symfony/symfony/pull/32032/files#r322150801
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 10, 2019
@nicolas-grekas nicolas-grekas mentioned this pull request Sep 10, 2019
Merged
@fabpot
Copy link
Member
fabpot commented Sep 10, 2019

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Sep 10, 2019
@fabpot
bug #33525 [DI] fix Preloader (nicolas-grekas)
1c3d409 
This PR was merged into the 4.4 branch.

Discussion
----------

[DI] fix Preloader

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/32032/files#r322150801
| License       | MIT
| Doc PR        | -

Commits
-------

4cc8641 [DI] fix Preloader
@fabpot fabpot merged commit 4cc8641 into symfony:4.4 Sep 10, 2019
@nicolas-grekas nicolas-grekas deleted the di-dirname branch September 10, 2019 10:03
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @stof @carsonbot
0