8000 [MonologBridge] Bump min version for monolog ^1.25 and drop dead code by lyrixx · Pull Request #33492 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[MonologBridge] Bump min version for monolog ^1.25 and drop dead code #33492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2019
Merged

[MonologBridge] Bump min version for monolog ^1.25 and drop dead code #33492

merged 1 commit into from
Sep 6, 2019

Conversation

@lyrixx
Copy link
Member
@lyrixx lyrixx commented Sep 6, 2019
Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@lyrixx lyrixx mentioned this pull request Sep 6, 2019
Merged
@lyrixx lyrixx changed the title [MonologBridge] Bump min version for monolog ^1.25 and drop dead code [DO NOT MERGE][MonologBridge] Bump min version for monolog ^1.25 and drop dead code Sep 6, 2019
@lyrixx
Copy link
Member Author
lyrixx commented Sep 6, 2019 •
edited
Loading

I block this PR: It will need Seldaek/monolog#1374 and a new monolog release

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 6, 2019
nicolas-grekas
nicolas-grekas reviewed Sep 6, 2019
View reviewed changes
nicolas-grekas
nicolas-grekas reviewed Sep 6, 2019
View reviewed changes
@lyrixx
Copy link
Member Author
lyrixx commented Sep 6, 2019

Travis failures are not related

@lyrixx lyrixx changed the title [DO NOT MERGE][MonologBridge] Bump min version for monolog ^1.25 and drop dead code [MonologBridge] Bump min version for monolog ^1.25 and drop dead code Sep 6, 2019
@nicolas-grekas
Copy link
Member
nicolas-grekas commented Sep 6, 2019

Thank you @lyrixx.

nicolas-grekas added a commit that referenced this pull request Sep 6, 2019
@nicolas-grekas
minor #33492 [MonologBridge] Bump min version for monolog ^1.25 and d…
654b803 
…rop dead code (lyrixx)

This PR was merged into the 4.4 branch.

Discussion
----------

[MonologBridge] Bump min version for monolog ^1.25 and drop dead code

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

1e19c65 [MonologBridge] Bump min version for monolog ^1.25 and drop dead code
@nicolas-grekas nicolas-grekas merged commit 1e19c65 into symfony:4.4 Sep 6, 2019
@derrabus
Copy link
Member
derrabus commented Sep 6, 2019

Does that change also affect the minimal Monolog 2 version on master?

@lyrixx lyrixx deleted the monolog-simplify branch September 6, 2019 17:37
@lyrixx
Copy link
Member Author
lyrixx commented Sep 6, 2019

@derrabus I think it should be ok

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees

No one assigned

Labels

MonologBridge Status: Needs Review

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@lyrixx @nicolas-grekas @derrabus @carsonbot
0