8000 [Form] fix parameter type declaration and make fabbot happy by xabbuh · Pull Request #33349 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] fix parameter type declaration and make fabbot happy #33349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2019
Merged

[Form] fix parameter type declaration and make fabbot happy #33349

merged 1 commit into from
Aug 27, 2019

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Aug 26, 2019
Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Aug 26, 2019
@nicolas-grekas
Copy link
Member

This will make fabbot green and Travis red :)

@xabbuh
Copy link
Member Author
xabbuh commented Aug 26, 2019 •
edited
Loading

The Form component tests are green now. AppVeyor failure doesn't look related. green :)

@xabbuh xabbuh marked this pull request as ready for review August 26, 2019 20:25
nicolas-grekas
nicolas-grekas approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet :)

@fabpot
Copy link
Member
fabpot commented Aug 27, 2019

Thank you @xabbuh.

fabpot added a commit that referenced this pull request Aug 27, 2019
@fabpot
minor #33349 [Form] fix parameter type declaration and make fabbot ha…
c08b42a 
…ppy (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] fix parameter type declaration and make fabbot happy

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

19b2928 fix parameter type declaration and make fabbot happy
@fabpot fabpot merged commit 19b2928 into symfony:3.4 Aug 27, 2019
@xabbuh xabbuh deleted the pr-33332 branch August 27, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @nicolas-grekas @fabpot @yceruto @carsonbot
0