8000 Fix inconsistent return points by derrabus · Pull Request #33254 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix inconsistent return points #33254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2019
Merged

Fix inconsistent return points #33254

merged 1 commit into from
Aug 20, 2019

Conversation

derrabus
Copy link
Member
Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #17201 in preparation for #33228
License MIT
Doc PR N/A

That's #33252 on the 4.3 branch.

@derrabus derrabus changed the title Fix inconsistent return points. Fix inconsistent return points Aug 20, 2019
@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Aug 20, 2019
@nicolas-grekas nicolas-grekas force-pushed the bugfix/irp-4.3 branch 2 times, most recently from c9b55c0 to bbe38b9 Compare August 20, 2019 14:20
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

nicolas-grekas added a commit that referenced this pull request Aug 20, 2019
@nicolas-grekas
minor #33254 Fix inconsistent return points (derrabus)
cfb2184 
This PR was merged into the 4.3 branch.

Discussion
----------

Fix inconsistent return points

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17201 in preparation for #33228
| License       | MIT
| Doc PR        | N/A

That's #33252 on the 4.3 branch.

Commits
-------

c26c535 Fix inconsistent return points.
@nicolas-grekas nicolas-grekas merged commit c26c535 into symfony:4.3 Aug 20, 2019
@derrabus derrabus deleted the bugfix/irp-4.3 branch August 20, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @nicolas-grekas @carsonbot
0