Add types to private and final methods #33198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seriquynh
approved these changes
Aug 16, 2019
|
A mock in Workflow might have an issue, see tests. |
|
Maybe the fix related to the failing tests should go to #33197 btw? |
Merged
1ba948e to
2c3f0a0
Compare
|
The test was right. I cannot type-hint for |
xabbuh
reviewed
Aug 18, 2019
2c3f0a0 to
57ddb0a
Compare
57ddb0a to
349108f
Compare
5709991 to
01e0b0a
Compare
01e0b0a to
1b88067
Compare
fabpot
added a commit
that referenced
this pull request
Aug 18, 2019
…rabus) This PR was merged into the 4.3 branch. Discussion ---------- [Workflow] Added doc block for Registry::supports() | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Follows #33197, prepares #33198. Commits ------- c76fd13 Added doc block for Registry::supports().
fabpot
approved these changes
Aug 18, 2019
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Aug 18, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Add types to private and final methods | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A Backports from #33154. Commits ------- 1b88067 Add types to private and final methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports from #33154.