8000 Fixed markdown file by lyrixx · Pull Request #33142 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fixed markdown file #33142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2019
Merged

Fixed markdown file #33142

merged 1 commit into from
Aug 13, 2019

Conversation

lyrixx
Copy link
Member
@lyrixx lyrixx commented Aug 13, 2019
Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@lyrixx lyrixx requested a review from dunglas as a code owner August 13, 2019 15:11
@fabpot
Copy link
Member
fabpot commented Aug 13, 2019

I should probably add a check on fabbot :)

@lyrixx
Copy link
Member Author
lyrixx commented Aug 13, 2019

@fabpot Indeed. My IDE removes quite often trailing space when I open a new PR. At least this check will be awesome.
The command I used: fd .md | xargs sed -i 's/^[ \t]*$//;s/[ \t]*$//' (fd)
And for the syntax, I opened all files and checked by hand. My IDE highlight errror

@fabpot
Copy link
Member
fabpot commented Aug 13, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit 1369725 into symfony:3.4 Aug 13, 2019
fabpot added a commit that referenced this pull request Aug 13, 2019
@fabpot
minor #33142 Fixed markdown file (lyrixx)
7ae7a66 
This PR was squashed before being merged into the 3.4 branch (closes #33142).

Discussion
----------

Fixed markdown file

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

1369725 Fixed markdown file
@lyrixx lyrixx deleted the changelog branch August 13, 2019 17:47
@nicolas-grekas
Copy link
Member

@lyrixx could you please have a look at tests? It looks like this change broke them.

@lyrixx
Copy link
Member Author
lyrixx commented Aug 14, 2019

I will

@lyrixx lyrixx mentioned this pull request Aug 14, 2019
Merged
@lyrixx
Copy link
Member Author
lyrixx commented Aug 14, 2019

Sorry, for the delay, I was sleeping / commuting :)
I opened a new PR #33160 where I revert changes on fixtures files

nicolas-grekas added a commit that referenced this pull request Aug 14, 2019
@nicolas-grekas
minor #33160 Partially Revert "Remove trailing space in all markdown …
f23d139 
…files" (lyrixx)

This PR was merged into the 3.4 branch.

Discussion
----------

Partially Revert "Remove trailing space in all markdown files"

This reverts commit 5a3c198.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33142
| License       | MIT
| Doc PR        | -

Commits
-------

2aec7df Partially Revert "Remove trailing space in all markdown files"
hultberg pushed a commit to hultberg/symfony that referenced this pull request Sep 17, 2021
@fabpot
minor symfony#33142 Fixed markdown file (lyrixx)
d8c46bc 
This PR was squashed before being merged into the 3.4 branch (closes symfony#33142).

Discussion
----------

Fixed markdown file

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

1369725 Fixed markdown file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lyrixx @fabpot @nicolas-grekas @carsonbot
0