Bump minimal requirements #33094
Merged
Bump minimal requirements #33094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
commented
Aug 9, 2019
| $this->expectException('Symfony\Component\DependencyInjection\Exception\RuntimeException'); | ||
| $this->expectExceptionMessage('The definition for "\Symfony\Component\DependencyInjection\Tests\FooClass" has no class attribute, and appears to reference a class or interface. Please specify the class attribute explicitly or remove the leading backslash by renaming the service to "Symfony\Component\DependencyInjection\Tests\FooClass" to get rid of this error.'); | ||
| $this->expectException('Symfony\Component\DependencyInjection\Exception\InvalidArgumentException'); | ||
| $this->expectExceptionMessage('Service definition "\Symfony\Component\DependencyInjection\Tests\FooClass" has no class, and its name looks like a FQCN but it starts with a backslash; remove the leading backslash.'); |
There was a problem hiding this comment.
From CheckDefinitionValidityPass!
There was a problem hiding this comment.
perhaps im onto something - #33092 (comment)
xabbuh
approved these changes
Aug 9, 2019
9d87545 to
4b1dcc5
Compare
jderusse
commented
Aug 10, 2019
| $a[0] = &$a; | ||
| /** | ||
| * This test is identical to testFailingSerialization, but the tested data causes a segfault in PHP 7.2 | ||
| * https://github.com/sebastianbergmann/phpunit/issues/3790. |
There was a problem hiding this comment.
Opened an issue in PHP https://bugs.php.net/78397
f8430fe to
c874d3b
Compare
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 10, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Bump minimal requirements | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up #33079 Fix failures with lowest requirements in branch 4.3 Commits ------- c874d3b Bump minimal requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #33079 Fix failures with lowest requirements in branch 4.3