8000 [HttpKernel] Clarify error handler restoring process again by fancyweb · Pull Request #33031 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Clarify error handler restoring process again #33031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2019
Merged

[HttpKernel] Clarify error handler restoring process again #33031

merged 1 commit into from
Aug 8, 2019

Conversation

fancyweb
Copy link
Contributor
@fancyweb fancyweb commented Aug 8, 2019
Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33024
License MIT
Doc PR -

@fancyweb
Copy link
Contributor Author
fancyweb commented Aug 8, 2019

This can actually target 3.4. I will rebase.

@xabbuh
Copy link
Member
xabbuh commented Aug 8, 2019

For 3.4?

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 8, 2019
@fancyweb fancyweb changed the base branch from 4.3 to 3.4 8000 August 8, 2019 06:46
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 4ee54f0 into symfony:3.4 Aug 8, 2019
nicolas-grekas added a commit that referenced this pull request Aug 8, 2019
@nicolas-grekas
minor #33031 [HttpKernel] Clarify error handler restoring process aga…
e48d2c1 
…in (fancyweb)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] Clarify error handler restoring process again

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |#33024
| License       | MIT
| Doc PR        | -

Commits
-------

4ee54f0 [HttpKernel] Clarify error handler restoring process again
@fancyweb fancyweb deleted the deja-vu branch August 8, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
HttpKernel Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @xabbuh @nicolas-grekas @carsonbot
0