[Lock] add type-hint whenever possible

symfony · Simperfit · Aug 7, 2019 · Aug 7, 2019 · 8d5d8a75bff56f77f672158f4bbd3b642c3b6b9f
commit 8d5d8a75bff56f77f672158f4bbd3b642c3b6b9f
diff --git a/src/Symfony/Component/Lock/Lock.php b/src/Symfony/Component/Lock/Lock.php
@@ -114,7 +114,7 @@ public function acquire($blocking = false): ?bool
     /**
      * {@inheritdoc}
      */
-    public function refresh($ttl = null)
+    public function refresh(float $ttl = null)
     {
         if (null === $ttl) {
             $ttl = $this->ttl;

diff --git a/src/Symfony/Component/Lock/PersistingStoreInterface.php b/src/Symfony/Component/Lock/PersistingStoreInterface.php
@@ -49,5 +49,5 @@ public function exists(Key $key);
      *
      * @throws LockConflictedException
      */
-    public function putOffExpiration(Key $key, $ttl);
+    public function putOffExpiration(Key $key, float $ttl);
 }
diff --git a/src/Symfony/Component/Lock/Store/CombinedStore.php b/src/Symfony/Component/Lock/Store/CombinedStore.php
@@ -106,7 +106,7 @@ public function waitAndSave(Key $key)
     /**
      * {@inheritdoc}
      */
-    public function putOffExpiration(Key $key, $ttl)
+    public function putOffExpiration(Key $key, float $ttl)
     {
         $successCount = 0;
         $failureCount = 0;

diff --git a/src/Symfony/Component/Lock/Store/FlockStore.php b/src/Symfony/Component/Lock/Store/FlockStore.php
@@ -106,7 +106,7 @@ private function lock(Key $key, bool $blocking)
     /**
      * {@inheritdoc}
      */
-    public function putOffExpiration(Key $key, $ttl)
+    public function putOffExpiration(Key $key, float $ttl)
     {
         // do nothing, the flock locks forever.
     }

diff --git a/src/Symfony/Component/Lock/Store/MemcachedStore.php b/src/Symfony/Component/Lock/Store/MemcachedStore.php
@@ -83,7 +83,7 @@ public function waitAndSave(Key $key)
     /**
      * {@inheritdoc}
      */
-    public function putOffExpiration(Key $key, $ttl)
+    public function putOffExpiration(Key $key, float $ttl)
     {
         if ($ttl < 1) {
             throw new InvalidTtlException(sprintf('%s() expects a TTL greater or equals to 1 second. Got %s.', __METHOD__, $ttl));

diff --git a/src/Symfony/Component/Lock/Store/PdoStore.php b/src/Symfony/Component/Lock/Store/PdoStore.php
@@ -152,7 +152,7 @@ public function waitAndSave(Key $key)
     /**
      * {@inheritdoc}
      */
-    public function putOffExpiration(Key $key, $ttl)
+    public function putOffExpiration(Key $key, float $ttl)
     {
         if ($ttl < 1) {
             throw new InvalidTtlException(sprintf('%s() expects a TTL greater or equals to 1 second. Got %s.', __METHOD__, $ttl));

diff --git a/src/Symfony/Component/Lock/Store/RedisStore.php b/src/Symfony/Component/Lock/Store/RedisStore.php
@@ -86,7 +86,7 @@ public function waitAndSave(Key $key)
     /**
      * {@inheritdoc}
      */
-    public function putOffExpiration(Key $key, $ttl)
+    public function putOffExpiration(Key $key, float $ttl)
     {
         $script = '
             if redis.call("GET", KEYS[1]) == ARGV[1] then

diff --git a/src/Symfony/Component/Lock/Store/RetryTillSaveStore.php b/src/Symfony/Component/Lock/Store/RetryTillSaveStore.php
@@ -80,7 +80,7 @@ public function waitAndSave(Key $key)
     /**
      * {@inheritdoc}
      */
-    public function putOffExpiration(Key $key, $ttl)
+    public function putOffExpiration(Key $key, float $ttl)
     {
         $this->decorated->putOffExpiration($key, $ttl);
     }

diff --git a/src/Symfony/Component/Lock/Store/SemaphoreStore.php b/src/Symfony/Component/Lock/Store/SemaphoreStore.php
@@ -100,7 +100,7 @@ public function delete(Key $key)
     /**
         * {@inheritdoc}
      */
-    public function putOffExpiration(Key $key, $ttl)
+    public function putOffExpiration(Key $key, float $ttl)
     {
         // do nothing, the semaphore locks forever.
     }

diff --git a/src/Symfony/Component/Lock/Store/ZookeeperStore.php b/src/Symfony/Component/Lock/Store/ZookeeperStore.php
@@ -96,7 +96,7 @@ public function waitAndSave(Key $key)
     /**
      * {@inheritdoc}
      */
-    public function putOffExpiration(Key $key, $ttl)
+    public function putOffExpiration(Key $key, float $ttl)
     {
         // do nothing, zookeeper locks forever.
     }

diff --git a/src/Symfony/Component/Lock/Strategy/ConsensusStrategy.php b/src/Symfony/Component/Lock/Strategy/ConsensusStrategy.php
@@ -21,15 +21,15 @@ class ConsensusStrategy implements StrategyInterface
     /**
      * {@inheritdoc}
      */
-    public function isMet($numberOfSuccess, $numberOfItems)
+    public function isMet(int $numberOfSuccess, int $numberOfItems)
     {
         return $numberOfSuccess > ($numberOfItems / 2);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function canBeMet($numberOfFailure, $numberOfItems)
+    public function canBeMet(int $numberOfFailure, int $numberOfItems)
     {
         return $numberOfFailure < ($numberOfItems / 2);
     }

diff --git a/src/Symfony/Component/Lock/Strategy/StrategyInterface.php b/src/Symfony/Component/Lock/Strategy/StrategyInterface.php
@@ -26,7 +26,7 @@ interface StrategyInterface
      *
      * @return bool
      */
-    public function isMet($numberOfSuccess, $numberOfItems);
+    public function isMet(int $numberOfSuccess, int $numberOfItems);
 
     /**
      * Returns whether or not the quorum *could* be met.
@@ -39,5 +39,5 @@ public function isMet($numberOfSuccess, $numberOfItems);
      *
      * @return bool
      */
-    public function canBeMet($numberOfFailure, $numberOfItems);
+    public function canBeMet(int $numberOfFailure, int $numberOfItems);
 }
diff --git a/src/Symfony/Component/Lock/Strategy/UnanimousStrategy.php b/src/Symfony/Component/Lock/Strategy/UnanimousStrategy.php
@@ -21,15 +21,15 @@ class UnanimousStrategy implements StrategyInterface
     /**
      * {@inheritdoc}
      */
-    public function isMet($numberOfSuccess, $numberOfItems)
+    public function isMet(int $numberOfSuccess, int $numberOfItems)
     {
         return $numberOfSuccess === $numberOfItems;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function canBeMet($numberOfFailure, $numberOfItems)
+    public function canBeMet(int $numberOfFailure, int $numberOfItems)
     {
         return 0 === $numberOfFailure;
     }