[Mailer] added debug info to TransportExceptionInterface #32896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While debugging, one can do something like this: try {
$sent = $transport->send($email);
} catch (TransportExceptionInterface $e) {
print $e->getDebug()."\n";
throw $e;
}
if ($sent) {
print $sent->getDebug()."\n";
} |
fabpot
added a commit
that referenced
this pull request
Aug 3, 2019
…ce (fabpot) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] added debug info to TransportExceptionInterface | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | ~ In 4.4, you can get the debug information for the SMTP/HTTP data via `$message->getDebug()` (see #32583). But the data are probably even more important when there is an exception. That's what I implemented in this PR. Commits ------- 39ebb84 [Mailer] added debug info to TransportExceptionInterface
This was referenced Aug 3, 2019
fabpot
added a commit
that referenced
this pull request
Aug 3, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Add debug info on HTTP transport exceptions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Same as #32896 but for HTTP transports. Commits ------- 4cfb4b9 [Mailer] added debug info on HTTP transport exceptions
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4.4, you can get the debug information for the SMTP/HTTP data via
$message->getDebug()(see #32583). But the data are probably even more important when there is an exception. That's what I implemented in this PR.