8000 [Messenger] DispatchAfterCurrentBusMiddleware does not cancel messages from delayed handlers by BastienClement · Pull Request #32497 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] DispatchAfterCurrentBusMiddleware does not cancel messages from delayed handlers #32497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2019
Merged

[Messenger] DispatchAfterCurrentBusMiddleware does not cancel messages from delayed handlers #32497

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35c76a3
Added tests for #32370
Nyholm Jul 9, 2019
1f5c8a6
Cancel delayed message if handler fails
BastienClement Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Cancel delayed message if handler fails
  • Loading branch information
@BastienClement
BastienClement committed Jul 11, 2019
commit 1f5c8a6790aba61e736461ab938321aa12fe42a8
4 changes: 4 additions & 0 deletions src/Symfony/Component/Messenger/Middleware/DispatchAfterCurrentBusMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,16 @@ public function handle(Envelope $envelope, StackInterface $stack): Envelope
// "Root dispatch" call is finished, dispatch stored messages.
$exceptions = [];
while (null !== $queueItem = array_shift($this->queue)) {
// Save how many messages are left in queue before handling the message
$queueLengthBefore = \count($this->queue);
try {
// Execute the stored messages
$queueItem->getStack()->next()->handle($queueItem->getEnvelope(), $queueItem->getStack());
} catch (\Exception $exception) {
// Gather all exceptions
$exceptions[] = $exception;
// Restore queue to previous state
$this->queue = \array_slice($this->queue, 0, $queueLengthBefore);
}
}

Expand Down
0