8000 [FrameworkBundle] Added type declarations where possible by derrabus · Pull Request #32480 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Added type declarations where possible #32480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2019
Merged

[FrameworkBundle] Added type declarations where possible #32480

merged 1 commit into from
Jul 27, 2019

Conversation

derrabus
Copy link
Member
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179
License MIT
Doc PR N/A

@derrabus derrabus mentioned this pull request Jul 10, 2019
Closed
57 tasks
@derrabus derrabus force-pushed the improvements/framework-bundle-types branch from 2570663 to 377f5ed Compare July 10, 2019 11:37
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jul 11, 2019
@fabpot
Copy link
Member
fabpot commented Jul 27, 2019

Thank you @derrabus.
8000

@fabpot fabpot merged commit 377f5ed into symfony:master Jul 27, 2019
fabpot added a commit that referenced this pull request Jul 27, 2019
@fabpot
minor #32480 [FrameworkBundle] Added type declarations where possible…
45148dd 
… (derrabus)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[FrameworkBundle] Added type declarations where possible

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | N/A

Commits
-------

377f5ed [FrameworkBundle] Added type declarations where possible.
@fabpot fabpot mentioned this pull request Jul 27, 2019
Merged
@derrabus derrabus deleted the improvements/framework-bundle-types branch July 27, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @fabpot @nicolas-grekas @carsonbot
0