8000 [Validator] Change Length::$allowEmptyString default to false & make it optional by ogizanagi · Pull Request #32373 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Change Length::$allowEmptyString default to false & make it optional #32373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2019
Merged

[Validator] Change Length::$allowEmptyString default to false & make it optional #32373

merged 1 commit into from
Jul 5, 2019

Conversation

@ogizanagi
Copy link
Contributor
@ogizanagi ogizanagi commented Jul 4, 2019 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tests pass? should pass after #32372
Fixed tickets #31528
License MIT
Doc PR TODO: change default value and mention it's optional Done. Thx @javiereguiluz

@ogizanagi ogizanagi added this to the 5.0 milestone Jul 4, 2019
@javiereguiluz
Copy link
Member
javiereguiluz commented Jul 4, 2019

Note: the needed changes in the docs have already been made:

@fabpot
Copy link
Member
fabpot commented Jul 5, 2019

Thank you @ogizanagi.

@fabpot fabpot mentioned this pull request Jul 5, 2019
Closed
@fabpot fabpot merged commit 26b804e into symfony:master Jul 5, 2019
fabpot added a commit that referenced this pull request Jul 5, 2019
@fabpot
feature #32373 [Validator] Change Length::$allowEmptyString default t…
f065c41 
…o false & make it optional (ogizanagi)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Validator] Change Length::$allowEmptyString default to false & make it optional

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | yes     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | should pass after #32372    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #31528   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | ~TODO: change default value and mention it's optional~ Done. Thx @javiereguiluz

Commits
-------

26b804e [Validator] Change Length::$allowEmptyString default to false & make it optional
@ogizanagi ogizanagi deleted the rm/deprec/validator/length branch July 5, 2019 05:45
@fabpot fabpot mentioned this pull request Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

+1 more reviewer

@Simperfit Simperfit Simperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

BC Break Feature Status: Reviewed Validator

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ogizanagi @javiereguiluz @fabpot @Simperfit @carsonbot
0