[Security] Added type-hints to password encoders #32352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7f758d to
d763e63
Compare
derrabus
commented
Jul 3, 2019
| @@ -299,3 +292,30 @@ protected function getProvider($user = null, $userChecker = null, $passwordEncod | |||
| return new DaoAuthenticationProvider($userProvider, $userChecker, 'key', $encoderFactory); | |||
| } | |||
| } | |||
|
|
|||
| class TestUser implements UserInterface | |||
There was a problem hiding this comment.
💡 UserInterface wasn't mocked properly in the tests: getPassword() returned null where it shouldn't. This caused problems with the new type-hints, so I switched to a dummy implementation instead of bloating the mocking code.
57 tasks
fabpot
approved these changes
Jul 4, 2019
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Security] Added type-hints to password encoders | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A This PR adds type declarations to all implementations of `PasswordEncoderInterface` and `UserPasswordEncoderInterface`. Commits ------- d763e63 [Security] Added type-hints to password encoders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type declarations to all implementations of
PasswordEncoderInterfaceandUserPasswordEncoderInterface.