8000 [CssSelector] [5.0] Add type-hint whenever possible by Simperfit · Pull Request #32328 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
/ symfony Public

[CssSelector] [5.0] Add type-hint whenever possible #32328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2019
Merged

[CssSelector] [5.0] Add type-hint whenever possible #32328

merged 1 commit into from
Jul 5, 2019

Conversation

Simperfit
Copy link
Contributor
Q A
Branch? 5.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets contribute to #32179
License MIT
Doc PR none

Add type hint to css selector ;).

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jul 3, 2019
@derrabus derrabus mentioned this pull request Jul 3, 2019
Closed
57 tasks
@fabpot
Copy link
Member
fabpot commented Jul 5, 2019

Thank you @Simperfit.

@fabpot fabpot merged commit 3e647d4 into symfony:master Jul 5, 2019
fabpot added a commit that referenced this pull request Jul 5, 2019
@fabpot
minor #32328 [CssSelector] [5.0] Add type-hint whenever possible (Sim…
c1fe1fa 
…perfit)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[CssSelector] [5.0] Add type-hint whenever possible

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | contribute to #32179   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none  <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Add type hint to css selector ;).

Commits
-------

3e647d4 [CssSelector] [5.0] Add type-hint whenever possible
@Simperfit Simperfit deleted the feature/add-type-hint-to-css-selector branch July 5, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@smoench smoench smoench approved these changes

Assignees
No one assigned
Labels
CssSelector Status: Reviewed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Simperfit @fabpot @smoench @nicolas-grekas @carsonbot
0