E531 [Templating] Added type-hints to all classes by derrabus · Pull Request #32313 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@derrabus
Copy link
Member
@derrabus derrabus commented Jul 1, 2019
F440
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179
License MIT
Doc PR N/A

This PR added type-hints to all classes of the templating component.

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jul 3, 2019
@derrabus derrabus force-pushed the improvement/type-hints-on-templating branch from f437345 to 92e6e8d Compare July 6, 2019 19:13
@derrabus derrabus force-pushed the improvement/type-hints-on-templating branch from 92e6e8d to 5626830 Compare July 6, 2019 19:20
@fabpot
Copy link
Member
fabpot commented Jul 8, 2019

Thank you @derrabus.

@fabpot fabpot merged commit 5626830 into symfony:master Jul 8, 2019
fabpot added a commit that referenced this pull request Jul 8, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Templating] Added type-hints to all classes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | N/A

This PR added type-hints to all classes of the templating component.

Commits
-------

5626830 [Templating] Added type-hints to all classes.
@derrabus derrabus deleted the improvement/type-hints-on-templating branch July 10, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0