8000 [Templating] Added type-hints to all classes by derrabus · Pull Request #32313 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Templating] Added type-hints to all classes #32313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2019
Merged

[Templating] Added type-hints to all classes #32313

merged 1 commit into from
Jul 8, 2019

Conversation

derrabus
Copy link
Member
@derrabus derrabus commented Jul 1, 2019
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179
License MIT
Doc PR N/A

This PR added type-hints to all classes of the templating component.

@derrabus derrabus mentioned this pull request Jul 1, 2019
Closed
57 tasks
Tobion
Tobion reviewed Jul 2, 2019
View reviewed changes
Tobion
Tobion reviewed Jul 2, 2019
View reviewed changes
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jul 3, 2019
@derrabus derrabus force-pushed the improvement/type-hints-on-templating branch from f437345 to 92e6e8d Compare July 6, 2019 19:13
@derrabus derrabus force-pushed the improvement/type-hints-on-templating branch from 92e6e8d to 5626830 Compare July 6, 2019 19:20
@fabpot
Copy link
Member
fabpot commented Jul 8, 2019

Thank you @derrabus.

@fabpot fabpot merged commit 5626830 into symfony:master Jul 8, 2019
fabpot added a commit that referenced this pull request Jul 8, 2019
@fabpot
minor #32313 [Templating] Added type-hints to all classes (derrabus)
e071953 
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Templating] Added type-hints to all classes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | N/A

This PR added type-hints to all classes of the templating component.

Commits
-------

5626830 [Templating] Added type-hints to all classes.
@derrabus derrabus deleted the improvement/type-hints-on-templating branch July 10, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobion Tobion Tobion left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Templating
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @fabpot @Tobion @nicolas-grekas @carsonbot
0