[Cache] [5.0] Add type-hint to the Cache component. #32282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
|
Thank you @Simperfit. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 30, 2019
…perfit) This PR was merged into the 5.0-dev branch. Discussion ---------- [Cache] [5.0] Add type-hint to the Cache component. | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | Contribute to #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | none <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Add type-hint in the cache component whenever possible. Commits ------- 0a41f6c [Cache] [5.0] add type hint to cache
Tobion
reviewed
Jul 1, 2019
| @@ -107,7 +107,7 @@ function ($deferred, $namespace, &$expiredIds) use ($getId) { | |||
| * | |||
| * @return AdapterInterface | |||
| */ | |||
| public static function createSystemCache($namespace, $defaultLifetime, $version, $directory, LoggerInterface $logger = null) | |||
| public static function createSystemCache(string $namespace, int $defaultLifetime, string $version, string $directory, LoggerInterface $logger = null) | |||
There was a problem hiding this comment.
all the param phpdoc should be removed
There was a problem hiding this comment.
btw, I also think the method should not be in AbstractAdapter. It get's inherited to all adapters. But it not meant to be overwritten or called with late static binding. It's a plain factory method, independent of all the adapters.
Tobion
added a commit
that referenced
this pull request
Jul 2, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Cache] finish type-hints | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Finish leftovers from #32282 Commits ------- 1919c7d [Cache] finish type-hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type-hint in the cache component whenever possible.