[Validator] add parameter type hints to the Validator component #32264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #32179 |
| License | MIT |
| Doc PR |
414545f to
df3a5cb
Compare
57 tasks
fabpot
approved these changes
Jun 29, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 29, 2019
…mponent (xabbuh) This PR was merged into the 5.0-dev branch. Discussion ---------- [Validator] add parameter type hints to the Validator component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | Commits ------- df3a5cb add parameter type hints to the Validator component
derrabus
reviewed
Jun 29, 2019
| @@ -28,7 +28,7 @@ public function __construct(ManagerRegistry $registry) | |||
| $this->registry = $registry; | |||
| } | |||
|
|
|||
| public function initialize($object) | |||
| public function initialize(object $object) | |||
There was a problem hiding this comment.
With this change, DoctrineBridge 5.0 will become incompatible with Validator 4.4. We should either revert this line or update the composer.json file of DoctrineBridge.
nicolas-grekas
added a commit
that referenced
this pull request
Aug 16, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [DoctrineBridge] conflict with Validator < 5.0 | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32264 (comment) | License | MIT | Doc PR | Commits ------- f8517cf conflict with Validator < 5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.