8000 [Validator] remove invalid test case by xabbuh · Pull Request #32250 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Validator] remove invalid test case #32250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Jun 28, 2019
Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Spotted while working on #32179 for the Validator component. Using property paths for comparison when validating arrays simply does not work.

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 9000c1e into symfony:4.3 Jun 28, 2019
nicolas-grekas added a commit that referenced this pull request Jun 28, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

[Validator] remove invalid test case

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Spotted while working on #32179 for the Validator component. Using property paths for comparison when validating arrays simply does not work.

Commits
-------

9000c1e remove invalid test case
@xabbuh xabbuh deleted the invalid-test-cases-4.3 branch June 28, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0