10000 [Mailer] fix tests on Windows by fabpot · Pull Request #32228 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] fix tests on Windows #32228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

[Mailer] fix tests on Windows #32228

merged 1 commit into from
Jun 27, 2019

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Jun 27, 2019
Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jun 27, 2019
@nicolas-grekas
Copy link
Member

First PR for 4.3 green for a few days \o/

@fabpot fabpot merged commit 90f61e9 into symfony:4.3 Jun 27, 2019
fabpot added a commit that referenced this pull request Jun 27, 2019
@fabpot
minor #32228 [Mailer] fix tests on Windows (fabpot)
00e1367 
This PR was merged into the 4.3 branch.

Discussion
----------

[Mailer] fix tests on Windows

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

90f61e9 [Mailer] fixed tests on Windows
@fabpot fabpot deleted the mailer-test-fix-windows branch July 18, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@fabpot @nicolas-grekas @carsonbot
0