8000 Make BuferringLogger classes internal and final by fabpot · Pull Request #32219 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Make BuferringLogger classes internal and final #32219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

Make BuferringLogger classes internal and final #32219

merged 1 commit into from
Jun 27, 2019

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Jun 27, 2019
Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

The BufferingLogger classes are internal code that nobody should use directly. Let's make it clear.

@fabpot fabpot force-pushed the buffering-logger branch 3 times, most recently from f46e76b to da34947 Compare June 27, 2019 12:59
@fabpot fabpot force-pushed the buffering-logger branch from da34947 to 7dd391e Compare June 27, 2019 13:22
@fabpot fabpot merged commit 7dd391e into symfony:4.4 Jun 27, 2019
fabpot added a commit that referenced this pull request Jun 27, 2019
@fabpot
bug #32219 Make BuferringLogger classes internal and final (fabpot)
acd7bd6 
This PR was merged into the 4.4 branch.

Discussion
----------

Make BuferringLogger classes internal and final

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

The `BufferingLogger` classes are internal code that nobody should use directly. Let's make it clear.

Commits
-------

7dd391e made BuferringLogger classes internal and final
stof
stof reviewed Jun 27, 2019
View reviewed changes
src/Symfony/Component/ErrorHandler/BufferingLogger.php
@@ -18,7 +18,7 @@
*
* @author Nicolas Grekas <p@tchwork.com>
*/
class BufferingLogger extends AbstractLogger
final class BufferingLogger extends AbstractLogger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you still haven't marked it as @internal

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my mind after a talk with @nicolas-grekas

@fabpot fabpot deleted the buffering-logger branch July 18, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments 61D2

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Deprecation Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fabpot @nicolas-grekas @stof @yceruto @carsonbot
0